ci(bug): Update permissions in JSON rpc relay for GITHUB_TOKEN (#3183) #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**: Added `packages: write` permission per https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic May need to modify other files modified by #3124 **Related Issue(s)**: Relates to #3124 Relates to #3182 Signed-off-by: Roger Barker <[email protected]>
quiet-node
previously approved these changes
Oct 30, 2024
Test Results 21 files + 1 280 suites +19 34m 42s ⏱️ - 1m 18s For more details on these failures, see this check. Results for commit b57e6f7. ± Comparison against base commit 024a7c5. ♻️ This comment has been updated with latest results. |
Nana-EC
previously approved these changes
Oct 30, 2024
ebadiere
dismissed stale reviews from rbarkerSL, Nana-EC, and quiet-node
via
3c23f51
ebadiere
force-pushed
the
3182-update-json-token-permissions-cherry-pick
branch
from
3c23f51
to
39a12e9
Compare
* chore: divided hbar limtier tests into different batches Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed acceptance.yml Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
|
quiet-node
approved these changes
Oct 31, 2024
Nana-EC
approved these changes
Oct 31, 2024
jeromy-cannon
approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3186 +/- ##
================================================
- Coverage 83.39% 83.14% -0.26%
================================================
Files 66 69 +3
Lines 4283 4444 +161
Branches 835 873 +38
================================================
+ Hits 3572 3695 +123
- Misses 471 502 +31
- Partials 240 247 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix.
Description:
Added
packages: writepermission perhttps://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic May need to modify other files modified by #3124
Related Issue(s):
Relates to #3124
Relates to #3182
Fixes #3124